-
-
Notifications
You must be signed in to change notification settings - Fork 774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Gleam to Linguist #477
Comments
I like this idea a lot but I'm not sure we qualify yet. Here it say we should have 1000s of code examples and be able to demonstrate real world code on GitHub. Having more Gleam projects on GitHub would be beneficial for this, and it would be good for us to see how it is being used. I wonder if we can encourage this somehow |
Just an FYI: We need "hundreds of repositories". We only need thousands of code examples if the extension conflicts with one already in Linguist. I think this might be worthwhile to pursue, especially as Linguist lets PRs linger if they are not ready yet. |
Wonderful news! Would someone like to take the lead here? |
I would in general, but I'm not sure if I know enough about gleam to create the grammar for it. I'd be happy to submit the Linguist PR if we could find/create the grammar file. |
That would be great @brightly-salty ! I'll help out if any issues arise. I believe we can use the grammar from the vscode plugin https://github.com/gleam-lang/vscode-gleam/blob/main/syntaxes/gleam.tmLanguage.json |
@brightly-salty After doing some digging it seems we have about 70 repos on GitHub. This is not enough yet, so let's focus on other things + getting more Gleam code on GitHub. |
I think there are enough repos using Gleam now. I searched GitHub and found a lot of repos solving Advent of Code 2021 in Gleam. So I downloaded the first 1000 file entries that have ".gleam" in their path, filter by paths that end with ".gleam" and group by repository, which told me that the files are from 95 different repositories. And I was only able to download 1000 file entries due to rate limits; according to the GitHub API there are over 11,000. |
@lpil @gamebox I filed a PR: github-linguist/linguist#5706 |
Current PR for tracking: github-linguist/linguist#5688 |
It's finally here!!! |
Looks like we can just add Gleam to Linguist. I’ll link an example PR. You can assign as well since I’m not going to do much more on incremental until v0.8 ships
github-linguist/linguist#4759
The text was updated successfully, but these errors were encountered: