Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Truncated Dates (bday / without years) are not parsed #38

Open
sebilasse opened this issue Nov 19, 2016 · 2 comments · May be fixed by #39
Open

Truncated Dates (bday / without years) are not parsed #38

sebilasse opened this issue Nov 19, 2016 · 2 comments · May be fixed by #39

Comments

@sebilasse
Copy link

sebilasse commented Nov 19, 2016 •
edited
Loading

Using truncated representations of dates for birth date is often good practice as noted in the vcard spec http://microformats.org/wiki/h-card#dt-bday

"--12-28"
Apart from citing parecki's birthday from the public h-card (send him much gifts) I'll look into it now for a fix [problem is in the intermediate step we would have to use the year 9999 and replace it afterwards, one reason why I am using a format like in my nlp module ].

Feel free to look into the following PR ...
sebilasse added a commit to sebilasse/microformat-node that referenced this issue Nov 19, 2016
@sebilasse
Parse truncated dates as such
84bebc9 
fixes glennjones#38
@sebilasse sebilasse linked a pull request Nov 19, 2016 that will close this issue
Open
@sebilasse
Copy link
Author

The problem is that it is invalid in JS then.
Maybe we should omit the replace in line 989 and parse it with year '9999' then ...

sebilasse added a commit to sebilasse/microformat-node that referenced this issue Nov 19, 2016
@sebilasse
better fix ...
bf80c21 
better fix for glennjones#38
@sebilasse
Copy link
Author

I corrected the PR so that it would be always this year if the date without year is still happening this year and next year if not ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Parse truncated dates as such sebilasse/microformat-node
1 participant
@sebilasse