Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sum and difference bodies #23

Open
4 tasks
b-butler opened this issue Nov 14, 2019 · 0 comments
Open
4 tasks

Sum and difference bodies #23

b-butler opened this issue Nov 14, 2019 · 0 comments
Assignees
@danevans09 @tfteague
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@b-butler
Copy link
Member

Description

Taking the sum or difference body of two shapes in 2D or 3D would not be difficult to implement and would be a nice feature. This could use duck typing to work with 2D or 3D vectors as well. I would recommend overwriting the __add__ and __sub__ methods of Poly classes for this.

Tasks

  • Create functions to calculate the sum and difference body and wrap results in the correct object
  • Use these functions to allow shape1 + shape2 and shape1 - shape2
  • Document these function
  • write unit tests for these functions
@b-butler b-butler added good first issue Good for newcomers enhancement New feature or request labels Nov 14, 2019
@danevans09 danevans09 self-assigned this Nov 21, 2019
@vyasr vyasr mentioned this issue Jan 19, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danevans09 danevans09

@tfteague tfteague

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@b-butler @danevans09 @tfteague