Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for adding types #664

Closed
jglaser opened this issue May 29, 2020 · 1 comment · Fixed by #1084
Closed

Remove support for adding types #664

jglaser opened this issue May 29, 2020 · 1 comment · Fixed by #1084
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@jglaser
Copy link
Contributor

jglaser commented May 29, 2020

Description

I am thinking about adding per-type tuning in HMPC. To avoid too much complexity, we could remove the support for dynamically changing the number of particle types when the state of the simulation is initialized, and only allow setting the number of particle types through the snapshot.

Proposed solution

remove slotNumTypesChange() methods.

Additional context

Will be more obvious in the context of an upcoming Autotuner related PR.

Developer

perhaps. Removing functionality is easy :)

@jglaser jglaser added the enhancement New feature or request label May 29, 2020
@jglaser jglaser added this to the v3.0 milestone May 29, 2020
@joaander joaander removed this from the v3.0.beta.1 milestone Oct 7, 2020
@joaander joaander added the good first issue Good for newcomers label Jul 21, 2021
@joaander
Copy link
Member

Related to #819 which needs to document the intended purpose of the snapshot save and reload commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants