A few small fixes to documentation #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default branch is `trunk`, not `main`.
tcmoore3
requested review from
a team and
SchoeniPhlippsn
and removed request for
a team
There is no CONTRIBUTORS.md file
tcmoore3
changed the title
joaander
requested changes
Sep 19, 2023
.github/PULL_REQUEST_TEMPLATE.md
Outdated
| @@ -17,4 +17,3 @@ Resolves #??? | |||
|
|
|||
| - [ ] I have reviewed the [**Contributor Guidelines**](https://github.com/glotzerlab/hoomd-validation/blob/trunk/CONTRIBUTING.md). | |||
| - [ ] I agree with the terms of the [**HOOMD-blue Contributor Agreement**](https://github.com/glotzerlab/hoomd-validation/blob/trunk/ContributorAgreement.md). | |||
| - [ ] My name is on the list of contributors (`CONTRIBUTORS.md`) in the pull request source branch. | |||
There was a problem hiding this comment.
Keep this line and instead add CONTRIBUTORS.md along with the needed .mailmap so that git shortlog produces the expected results.
Here are the contributors on trunk after removing bots:
324 Joshua A. Anderson <[email protected]>
106 Tommy Waltmann <[email protected]>
19 Tommy Waltmann <[email protected]>
10 tommy-waltmann <[email protected]>
6 Tim Moore <[email protected]>
6 Tim Moore <[email protected]>
3 Brandon Butler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CONTRIBUTING.mdto reflect that the default branch istrunk, notmainMotivation and context
Code–documentation consistency = good
How has this been tested?
Visual inspection of relevant markdown files.
Checklist:
CONTRIBUTORS.md) in the pull request source branch.