Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only 1 Notes instance appears on dashboard #74

Closed
tcmoore3 opened this issue Oct 28, 2019 · 1 comment · May be fixed by #182
Closed

Only 1 Notes instance appears on dashboard #74

tcmoore3 opened this issue Oct 28, 2019 · 1 comment · May be fixed by #182
Assignees
@cbkerr
Labels
bug Something isn't working

Comments

@tcmoore3
Copy link
Member

Description

When attempting to add multiple instances of the Notes module to a dashboard, only the first one (passed to the modules argument of PlotDashboard) actually appears on the dashboard.

To reproduce

from signac_dashboard import Dashboard
from signac_dashboard.modules import StatepointList, ImageViewer, VideoViewer
from signac_dashboard.modules import Notes, DocumentEditor

class PlotDashboard(Dashboard):
    def job_sorter(self, job):
        return job.sp.get('x', 0)


if __name__ == '__main__':
    modules = []
    notes_mod = Notes(name='notes 1', key='notes1')
    modules.append(notes_mod)
    other_notes_mod = Notes(name='notes 2', key='notes2')
    modules.append(other_notes_mod)
    PlotDashboard(modules=modules).main()

System configuration

$ python -c 'import platform; print(platform.platform()); import sys; print(sys.version); import signac_dashboard; print(signac_dashboard.__version__)'
Darwin-17.7.0-x86_64-i386-64bit
3.6.7 | packaged by conda-forge | (default, Jul  2 2019, 02:07:37) 
[GCC 4.2.1 Compatible Clang 4.0.1 (tags/RELEASE_401/final)]
0.2.5
@bdice bdice added the bug Something isn't working label Nov 20, 2019
@tcmoore3 tcmoore3 mentioned this issue Feb 18, 2022
Closed
11 tasks
@tcmoore3
Copy link
Member Author

This is a stale issue and the fix seems like it would involve quite a bit of reworking how the modules work, so I'm going to close. We can revisit if it become a major issue later on.

@tcmoore3 tcmoore3 closed this as not planned Won't fix, can't repro, duplicate, stale Aug 12, 2022
@cbkerr cbkerr self-assigned this Feb 13, 2023
@cbkerr cbkerr mentioned this issue Apr 3, 2023
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cbkerr cbkerr

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix/allow multiple notes glotzerlab/signac-dashboard
3 participants
@bdice @tcmoore3 @cbkerr