Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document that --pretend doesn't include arguments passed after "--" #60

Open
atravitz opened this issue Oct 30, 2019 · 2 comments
Open
Labels
good first issue Good for newcomers

Comments

@atravitz
Copy link
Collaborator

No description provided.

@mikemhenry
Copy link
Collaborator

I love all of these issues @atravitz! Can you add an example of what your running into?

@vyasr
Copy link
Contributor

vyasr commented Oct 31, 2019

Alyssa is using the feature of flow that allows you to pass arbitrary arguments to the scheduler, e.g. python project.py submit -n 1 -- -A=MY_ACCOUNT -l OTHER_RESOURCE. The way that we implement this is to literally pass these arguments through to the scheduler, e.g. sbatch -A=MY_ACCOUNT -l OTHER_RESOURCE script.sh, without actually modifying script.sh. As a result, using --pretend doesn't show the changes. I think the most straightforward option here is to simply print the submission command along with the script if flags is not None (or maybe all the time). I'm not inclined to actually change the behavior to actually modify the script, since I don't know if we can guarantee that all command line options actually map to scheduler directives that would be placed in a script and it would also require some extra template hackery to substitute existing lines with new ones if any directives were being overridden.

@bdice bdice added the good first issue Good for newcomers label Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants