Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run command treats warnings as errors, traceback is confusing. #559

Open
bdice opened this issue Aug 2, 2021 · 0 comments
Open

Run command treats warnings as errors, traceback is confusing. #559

bdice opened this issue Aug 2, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@bdice
Copy link
Member

bdice commented Aug 2, 2021

Description

I discussed an issue with @jdice where he saw a DeprecationWarning (raised here when job.get_id() is called) being treated as an exception in the run command (exception handling here). DeprecationWarning inherits from Warning, which inherits from Exception, thus deprecation warnings are treated like uncaught errors in the handler for Exception which is undesired behavior.

This specific problem was probably introduced with aggregation in 0.15, and may be resolved by #558, but the underlying problem probably affects all warnings and not just those related to the deprecated job.get_id().

To reproduce

TODO: Create minimal failing example of project.py that manually raises a DeprecationWarning, and see what happens in the traceback (make sure --show-traceback is disabled). Also check to see what happens if a warning is issued followed by an actual error. In my understanding of the problem, this may cause the warning to appear instead of the real error.

Error output

TODO

@bdice bdice added the bug Something isn't working label Aug 2, 2021
@bdice bdice added this to the v0.16.0 milestone Aug 2, 2021
@bdice bdice modified the milestones: v0.16.0, v0.17.0 Aug 16, 2021
@kidrahahjo kidrahahjo modified the milestones: v0.17.0, v0.18.0 Jan 11, 2022
@cbkerr cbkerr removed this from the v0.18.0 milestone Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants