Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

numpydoc style(signac/contrib/schema.py) #318

Merged
merged 13 commits into from
Apr 22, 2020

Conversation

ac-optimus
Copy link
Contributor

Description

issue #315

Motivation and Context

Types of Changes

  • Documentation update
  • Bug fix
  • New feature
  • Breaking change1

1The change breaks (or has the potential to break) existing functionality.

Checklist:

If necessary:

  • I have updated the API documentation as part of the package doc-strings.
  • I have created a separate pull request to update the framework documentation on signac-docs and linked it here.
  • I have updated the changelog and added all related issue and pull request numbers for future reference (if applicable). See example below.

Change of doc string to numpydoc in schema.py

@ac-optimus ac-optimus requested review from a team as code owners April 1, 2020 14:19
@ac-optimus ac-optimus changed the title numpydoc style numpydoc style(signac/contrib/schema.py) Apr 1, 2020
@codecov
Copy link

codecov bot commented Apr 2, 2020

Codecov Report

Merging #318 into numpy_docs will increase coverage by 0.01%.
The diff coverage is 87.50%.

Impacted file tree graph

@@              Coverage Diff               @@
##           numpy_docs     #318      +/-   ##
==============================================
+ Coverage       76.18%   76.19%   +0.01%     
==============================================
  Files              43       43              
  Lines            7076     7079       +3     
==============================================
+ Hits             5391     5394       +3     
  Misses           1685     1685              
Impacted Files Coverage Δ
signac/contrib/project.py 91.58% <50.00%> (ø)
signac/contrib/import_export.py 84.75% <100.00%> (ø)
signac/contrib/schema.py 97.65% <100.00%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update deb56fa...be9530b. Read the comment docs.

Copy link
Member

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggested some docstrings. This will need a few more iterations to be complete.

signac/contrib/schema.py Outdated Show resolved Hide resolved
signac/contrib/schema.py Outdated Show resolved Hide resolved
signac/contrib/schema.py Outdated Show resolved Hide resolved
signac/contrib/schema.py Outdated Show resolved Hide resolved
signac/contrib/schema.py Outdated Show resolved Hide resolved
signac/contrib/schema.py Outdated Show resolved Hide resolved
signac/contrib/schema.py Outdated Show resolved Hide resolved
signac/contrib/schema.py Outdated Show resolved Hide resolved
signac/contrib/schema.py Outdated Show resolved Hide resolved
signac/contrib/schema.py Outdated Show resolved Hide resolved
@vyasr vyasr requested review from a team and Tobias-Dwyer and removed request for a team April 4, 2020 16:53
@ac-optimus
Copy link
Contributor Author

@bdice @Tobias-Dwyer i have added all of the docstrings i can. Can you please help with the rest!

@ac-optimus ac-optimus requested a review from bdice April 10, 2020 11:19
Copy link
Member

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are some more suggested docstrings. There are still some missing.

signac/contrib/schema.py Outdated Show resolved Hide resolved
signac/contrib/schema.py Show resolved Hide resolved
signac/contrib/schema.py Outdated Show resolved Hide resolved
signac/contrib/schema.py Outdated Show resolved Hide resolved
signac/contrib/schema.py Show resolved Hide resolved
signac/contrib/schema.py Outdated Show resolved Hide resolved
signac/contrib/schema.py Show resolved Hide resolved
signac/contrib/schema.py Outdated Show resolved Hide resolved
signac/contrib/schema.py Outdated Show resolved Hide resolved
signac/contrib/schema.py Outdated Show resolved Hide resolved
@bdice
Copy link
Member

bdice commented Apr 10, 2020

@ac-optimus When you are able, please review the comments so far. Please click "Resolve conversation" on all the changes you have applied and only leave the comments that you aren't sure about. Try to fill some of the remaining docstrings, to the best of your ability. Then re-request my review and I can take another pass on anything that's left.

@ac-optimus
Copy link
Contributor Author

@ac-optimus When you are able, please review the comments so far. Please click "Resolve conversation" on all the changes you have applied and only leave the comments that you aren't sure about. Try to fill some of the remaining docstrings, to the best of your ability. Then re-request my review and I can take another pass on anything that's left.

@bdice done that.

@ac-optimus ac-optimus requested a review from bdice April 10, 2020 19:01
signac/contrib/schema.py Outdated Show resolved Hide resolved
signac/contrib/schema.py Outdated Show resolved Hide resolved
signac/contrib/schema.py Outdated Show resolved Hide resolved
signac/contrib/schema.py Outdated Show resolved Hide resolved
signac/contrib/schema.py Outdated Show resolved Hide resolved
signac/contrib/schema.py Outdated Show resolved Hide resolved
signac/contrib/schema.py Outdated Show resolved Hide resolved
signac/contrib/schema.py Outdated Show resolved Hide resolved
signac/contrib/schema.py Outdated Show resolved Hide resolved
signac/contrib/schema.py Outdated Show resolved Hide resolved
@ac-optimus ac-optimus requested a review from bdice April 15, 2020 14:33
@bdice bdice added the documentation Writing or editing documentation label Apr 16, 2020
@bdice bdice added this to the v1.5.0 milestone Apr 16, 2020
Copy link
Member

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@bdice bdice mentioned this pull request Apr 18, 2020
12 tasks
Copy link

@Tobias-Dwyer Tobias-Dwyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@vyasr vyasr merged commit c655af1 into glotzerlab:numpy_docs Apr 22, 2020
@bdice bdice added the doc-style Update docs to numpy doc style label May 7, 2020
mikemhenry pushed a commit that referenced this pull request Jul 22, 2020
* numpydoc style(signac/contrib/schema.py) (#318)

* numpydoc style(signac/contrib/project.py) (#320)

* numpydoc style(signac/contrib/job.py)  (#319)

* numpydoc style(signac/contrib/linked_view.py, signac/contrib/utility.py, signac/core/utility.py) (#326)

* numpydoc style(signac/contrib/errors.py, signac/contrib/filesystems.py, signac/contrib/filterparser.py, signac/contrib/hashing.py) (#322)

* numpydoc style (signac/contrib/collection.py) (#329)

* Make core submodule adhere to numpydoc conventions. (#339)

* add a docstring for public module (#337)

* numpydoc style (signac/contrib/import_export.py) (#333)

* Apply NumPy docstyle to remaining files in "signac" root. (#343)

* Apply fixes from minirst. (#356)

* Enforce pydocstyle in core, common, contrib. (#354)

Co-authored-by: Bradley Dice <[email protected]>
Co-authored-by: Alyssa Travitz <[email protected]>
Co-authored-by: Abhavya Chandra <[email protected]>
Co-authored-by: vyasr <[email protected]>
Co-authored-by: Pengji <[email protected]>
Co-authored-by: Mike Henry <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-style Update docs to numpy doc style documentation Writing or editing documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants