Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Numpy docstyle for core submodule #339

Merged
merged 1 commit into from
Jun 17, 2020
Merged

Numpy docstyle for core submodule #339

merged 1 commit into from
Jun 17, 2020

Conversation

bdice
Copy link
Member

@bdice bdice commented Jun 15, 2020

Description

Applied numpy docstyle to the core submodule.

Motivation and Context

Part of #315.

Types of Changes

  • Documentation update
  • Bug fix
  • New feature
  • Breaking change1

1The change breaks (or has the potential to break) existing functionality.

Checklist:

If necessary:

  • I have updated the API documentation as part of the package doc-strings.
  • I have created a separate pull request to update the framework documentation on signac-docs and linked it here.
  • I have updated the changelog and added all related issue and pull request numbers for future reference (if applicable). See example below.

@bdice bdice added the doc-style Update docs to numpy doc style label Jun 15, 2020
@bdice bdice added this to the v1.5.0 milestone Jun 15, 2020
@bdice bdice requested review from a team as code owners June 15, 2020 00:42
@bdice bdice self-assigned this Jun 15, 2020
@bdice bdice requested review from tcmoore3 and Charlottez112 and removed request for a team June 15, 2020 00:42
@bdice bdice changed the base branch from master to numpy_docs June 15, 2020 00:42
@bdice bdice changed the title Numpy docs core Numpy docstyle for core submodule Jun 15, 2020
@codecov
Copy link

codecov bot commented Jun 15, 2020

Codecov Report

Merging #339 into numpy_docs will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           numpy_docs     #339   +/-   ##
===========================================
  Coverage       76.22%   76.22%           
===========================================
  Files              43       43           
  Lines            7086     7088    +2     
===========================================
+ Hits             5401     5403    +2     
  Misses           1685     1685           
Impacted Files Coverage Δ
signac/core/attrdict.py 96.15% <100.00%> (+0.15%) ⬆️
signac/core/dict_manager.py 90.58% <100.00%> (ø)
signac/core/h5store.py 91.00% <100.00%> (ø)
signac/core/json.py 84.00% <100.00%> (+0.66%) ⬆️
signac/core/synceddict.py 96.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23e2888...b4258dd. Read the comment docs.

@@ -28,6 +29,7 @@ def __init__(self, prefix):

@property
def prefix(self):
"""Return the prefix."""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Necessary?

@tcmoore3 tcmoore3 merged commit fc7e615 into numpy_docs Jun 17, 2020
@tcmoore3 tcmoore3 deleted the numpy_docs_core branch June 17, 2020 14:23
mikemhenry pushed a commit that referenced this pull request Jul 22, 2020
* numpydoc style(signac/contrib/schema.py) (#318)

* numpydoc style(signac/contrib/project.py) (#320)

* numpydoc style(signac/contrib/job.py)  (#319)

* numpydoc style(signac/contrib/linked_view.py, signac/contrib/utility.py, signac/core/utility.py) (#326)

* numpydoc style(signac/contrib/errors.py, signac/contrib/filesystems.py, signac/contrib/filterparser.py, signac/contrib/hashing.py) (#322)

* numpydoc style (signac/contrib/collection.py) (#329)

* Make core submodule adhere to numpydoc conventions. (#339)

* add a docstring for public module (#337)

* numpydoc style (signac/contrib/import_export.py) (#333)

* Apply NumPy docstyle to remaining files in "signac" root. (#343)

* Apply fixes from minirst. (#356)

* Enforce pydocstyle in core, common, contrib. (#354)

Co-authored-by: Bradley Dice <[email protected]>
Co-authored-by: Alyssa Travitz <[email protected]>
Co-authored-by: Abhavya Chandra <[email protected]>
Co-authored-by: vyasr <[email protected]>
Co-authored-by: Pengji <[email protected]>
Co-authored-by: Mike Henry <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-style Update docs to numpy doc style
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants