Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Autoreformat doc to conform to numpydoc. #362

Closed
wants to merge 2 commits into from

Conversation

Carreau
Copy link

@Carreau Carreau commented Jul 31, 2020

One thing which is misparsed by numpydoc is

     Returns
     -------
-    NoneType or :class:`~signac.sync.FileTransferStats`
+    NoneType or : class:`~signac.sync.FileTransferStats`
         Returns stats if ``collect_stats`` is ``True``, else ``None``.

Which I of course did not add; So that might be a bug in NumPyDoc.

Partial work toward #344

Types of Changes

  • Documentation update
  • Bug fix
  • New feature
  • Breaking change1

Checklist:

One thing which is misparsed by numpydoc is

     Returns
     -------
-    NoneType or :class:`~signac.sync.FileTransferStats`
+    NoneType or : class:`~signac.sync.FileTransferStats`
         Returns stats if ``collect_stats`` is ``True``, else ``None``.

Which I of course did not add; So that might be a bug in NumPyDoc.

Partial work toward glotzerlab#344
@vyasr
Copy link
Contributor

vyasr commented Jul 31, 2020

Hey @Carreau thanks for the PR! This looks to be a duplicate of #361, was that intentional?

@b-butler
Copy link
Member

@Carreau should both PRs #362 and #361 be open?

@Carreau
Copy link
Author

Carreau commented Aug 17, 2020

Let's close 361 as this one was done with a more recent version of velin; still working on the RST parsing to fix more stuff but I didn't had much time recently.

@b-butler
Copy link
Member

Sounds good.

@bdice bdice changed the title DOC: Autoreformat doc to confrm to numpydoc. DOC: Autoreformat doc to conform to numpydoc. Aug 26, 2020
@csadorf
Copy link
Contributor

csadorf commented Mar 25, 2021

@Carreau Did you have a chance to work on the RST parsing?

@Carreau
Copy link
Author

Carreau commented Mar 26, 2021

Did you have a chance to work on the RST parsing?

tiny bit but not that much. I'm going to try applying to CZI EOSS4, for a related project that might need more work on RST parsing, I've also discovered https://github.com/stsewd/tree-sitter-rst which does a fairly good job and could be reused/contributed to.

@csadorf
Copy link
Contributor

csadorf commented Mar 26, 2021

@Carreau Ok, thx for the update. Let's leave the issue open then. Please let us know if we can be of any assistance.

@bdice
Copy link
Member

bdice commented May 6, 2021

I looked at a recent version of velin (which now supports being used as a pre-commit hook) but some of its suggestions weren't what I expected and might negatively impact our Sphinx docs rendering. Specifically handling of *args. I'm going to close this PR, we can always come back to the idea later but this PR has been stalled for long enough.

@bdice bdice closed this May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants