Fix(SavedSearch): Force user to validate criteria before saved search

[stonebuzz]

Checklist before requesting a review

Please delete options that are not relevant.

• I have read the CONTRIBUTING document.
• I have performed a self-review of my code.
• I have added tests that prove my fix is effective or that my feature works.
• This change requires a documentation update.

Description

• It fixes !35211

Perhaps an alternative to #18376.

After further review, I believe the issue here is that the saved search system expects the user to execute a search based on their criteria at least once (to include them in the URL).

See GenericView.js L102

const bs_modal = new bootstrap.Modal(modal.get(0), {show: false});
modal.on('show.bs.modal', () => {
    const params = JSON.parse(modal.attr('data-params'));
    params['url'] = window.location.pathname + window.location.search;
    modal.find('.modal-body').load(CFG_GLPI.root_doc + '/ajax/savedsearch.php', params);
});

If the user does not execute a search at least once, the default search for the item type is used and saved in the database.

Since I don’t see how to extract the search

convert it into a URL as shown here

and then pass it to the modal (from GenericView.js L102)

I simply propose checking whether window.location.search is not empty or does not correspond to a search reset (reset=reset).

Screenshots (if appropriate):

[stonebuzz]

Awaiting user feedback
!35211