Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rule ticket): standardization of actions on groups #18394

Open
wants to merge 2 commits into
base: 10.0/bugfixes
Choose a base branch
from
Open

feat(rule ticket): standardization of actions on groups #18394

wants to merge 2 commits into from
+56 −2

Conversation

Rom1-B
Copy link
Contributor

@Rom1-B Rom1-B commented Nov 27, 2024

Checklist before requesting a review

Please delete options that are not relevant.

  • I have read the CONTRIBUTING document.
  • I have performed a self-review of my code.
  • I have added tests that prove my fix is effective or that my feature works.
  • This change requires a documentation update.

Description

  • It fixes !35385
  • Here is a brief description of what this PR does

Allowing the same actions to all 3 types of groups

Screenshots (if appropriate):

image

cedric-anne
cedric-anne requested changes Nov 28, 2024
View reviewed changes
Copy link
Member

@cedric-anne cedric-anne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fromitem case should be updated too.

@cedric-anne cedric-anne added this to the 10.0.18 milestone Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdrienClairembault AdrienClairembault AdrienClairembault approved these changes

@cedric-anne cedric-anne cedric-anne approved these changes

@trasher trasher Awaiting requested review from trasher

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
10.0.18
Development

Successfully merging this pull request may close these issues.
3 participants
@Rom1-B @cedric-anne @AdrienClairembault