Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix xfailing regions test #14

Open
astrofrog opened this issue May 13, 2020 · 2 comments
Open

Fix xfailing regions test #14

astrofrog opened this issue May 13, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@astrofrog
Copy link
Member

In 486e113 I had to xfail a test that is failing because of changes in the regions translation.

@jsub1 - would you be able to take a look at this?

@astrofrog astrofrog added the bug Something isn't working label May 13, 2020
@jsub1
Copy link
Contributor

jsub1 commented May 13, 2020

@astrofrog The translation is supposed to fail because one of the ROIs is defined on the main component. 7b79fc1 removed where we checked for that. Does it make sense to try and expand translation to astropy regions for non-2D datasets?

@astrofrog
Copy link
Member Author

@jsub1 - for some reason the translation wasn't failing, which is why I had to xfail the test. I think ideally we'd like to get the translation to work for 3D+ datasets, I'm not sure though how we convey the information about which axes are covered by the regions. Feel free to take a stab at this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants