shellcheck failing on fedora32

[deepshikhaaa]

No description provided.

[deepshikhaaa]

shellcheck was not installed on community cage fedora builders and the job did not fail when there was no shellcheck. We need to have a proper check for the same.

And now since the AWS fedora builders have shellcheck https://github.com/gluster/gluster.org_ansible_configuration/blob/c0e209a3151c470dd6e953d7df154986e53bd0ba/roles/jenkins_builder/tasks/pkgs_job_shellcheck.yml and the inventory https://github.com/gluster/gluster.org_ansible_configuration/blob/4f8e7eda1e4e965ba63216af0bd602a55c6c2237/hosts#L46 , it started failing.

[deepshikhaaa]

Already discussed on the same #53

[mscherer]

It fail because we have warnings/errors. So the job is working in that it detect what is supposed to be detected (which it didn't before). I would suggest we make it non blocking or something since there is no fast/clear path toward a resolution (like, do we want to fix the 2M of warning ?)

[amarts]

Lets start with 'non-blocking' mode to start with! We can decide how to resolve it eventually!

[deepshikhaaa]

I have removed the shellcheck job from the list of jobs to pass before merging.

[pranithk]

I have removed the shellcheck job from the list of jobs to pass before merging.

@deepshikhaaa Is this change deployed? I just did recheck smoke on gluster/glusterfs#2259 and it still failed.

[deepshikhaaa]

@pranithk The issue you linked here is missing the approval from reviewers. shellcheck is not blocking the merge here.

@amarts @mscherer I am not sure how to deal with a situation where we might miss out on the new shellcheck related errors. Any suggestions?