Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle 403 errors for 1inch requests #95

Closed
MartinquaXD opened this issue Dec 18, 2024 · 0 comments · Fixed by #96
Closed

Handle 403 errors for 1inch requests #95

MartinquaXD opened this issue Dec 18, 2024 · 0 comments · Fixed by #96
Assignees
@squadgazzz

Comments

@MartinquaXD
Copy link
Contributor

The 1Inch API requires you to tell them which address wants to do the trade. Due to legal requirements they do not serve some addresses. In those cases the API call will return a 403 error.
Currently these get forwarded to the driver in a way that causes alerts like this although they are to be expected and don't indicate an error in the 1Inch API.
Screenshot 2024-12-18 at 08 18 30
@squadgazzz squadgazzz self-assigned this Dec 18, 2024
@squadgazzz squadgazzz mentioned this issue Dec 18, 2024
Merged
squadgazzz added a commit that referenced this issue Dec 20, 2024
@squadgazzz
Handle 403 errors for 1inch requests (#96)
ec9a318 
From the original issue #95:

> The 1Inch API requires you to tell them which address wants to do the
trade. Due to legal requirements they do not serve some addresses. In
those cases the API call will return a 403 error.
Currently these get forwarded to the driver in a way that causes alerts
like this although they are to be expected and don't indicate an error
in the 1Inch API.

All the 403 errors are considered `NotFound` to reduce false alerts.

Fixes #95
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@squadgazzz squadgazzz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handle 403 errors for 1inch requests gnosis/solvers
2 participants
@MartinquaXD @squadgazzz