Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Field Overwriting Issue with Embedded Structs in GORM #7237

Closed
TalesPalma opened this issue Oct 12, 2024 · 1 comment
Closed

Field Overwriting Issue with Embedded Structs in GORM #7237

TalesPalma opened this issue Oct 12, 2024 · 1 comment
Assignees
Labels

Comments

@TalesPalma
Copy link

TalesPalma commented Oct 12, 2024

GORM Playground Link

go-gorm/playground#1

Description

When using GORM to map structs to a database, an issue arises when embedding structs that have fields with the same name as those in the outer struct. Specifically, when embedding an Author struct within a Food struct, if both structs contain a field named Name, only the outer struct's field (Food.Name) is saved to the database, while the embedded struct's field (Author.Name) is ignored.

Example Code:

package main

import (
    "gorm.io/driver/sqlite"
    "gorm.io/gorm"
    "log"
)

type Author struct {
	gorm.Model
	Name  string `json:"name" gorm:"not null"`
	Email string `json:"email" gorm:"not null"`
}

type Food struct {
	gorm.Model
	Name          string `json:"name" gorm:"not null"`
	Price         string `json:"price" gorm:"not null"`
	Calories      string `json:"calories"`
	Proteins      string `json:"proteins"`
	Fats          string `json:"fats"`
	Carbohydrates string `json:"carbohydrates"`
	Sodium        string `json:"sodium"`
	Author        Author `json:"author" gorm:"embedded"`
}

func main() {
    db, err := gorm.Open(sqlite.Open("food.db"), &gorm.Config{})
    if err != nil {
        log.Fatalf("failed to connect to the database: %v", err)
    }

    // Auto-migrate the Food and Author structs to create the necessary tables
    if err := db.AutoMigrate(&Food{}); err != nil {
        log.Fatalf("failed to migrate: %v", err)
    }

    // Create a new Food item with an embedded Author
    food := Food{
        Name: "Pasta",
        Author: Author{
            Name:      "Chef Mario",
            Biography: "A renowned chef known for Italian cuisine.",
        },
    }

    // Save the food item to the database
    if err := db.Create(&food).Error; err != nil {
        log.Fatalf("failed to create food item: %v", err)
    }

    log.Println("Food item created successfully!")
}
@github-actions github-actions bot added the type:missing reproduction steps missing reproduction steps label Oct 12, 2024
Copy link

The issue has been automatically marked as stale as it missing playground pull request link, which is important to help others understand your issue effectively and make sure the issue hasn't been fixed on latest master, checkout https://github.com/go-gorm/playground for details. it will be closed in 30 days if no further activity occurs. if you are asking question, please use the Question template, most likely your question already answered https://github.com/go-gorm/gorm/issues or described in the document https://gorm.ioSearch Before Asking

@TalesPalma TalesPalma closed this as not planned Won't fix, can't repro, duplicate, stale Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants