fix(logger): Fixed fc is nil

[flc1125]

• Do only one thing
• Non breaking API changes
• Tested

[shedyfreak]

lftm, although I would suggest
l.Printf(l.traceWarnStr, utils.FileWithLineNum(), err, float64(elapsed.Nanoseconds())/1e6, "-", "-")
before returning

[flc1125]

lftm, although I would suggest l.Printf(l.traceWarnStr, utils.FileWithLineNum(), err, float64(elapsed.Nanoseconds())/1e6, "-", "-") before returning

If I return from there, I have code snippets of my switch, almost every one of them, will that cause redundant confusion.

	switch {
	case err != nil && l.LogLevel >= Error && (!errors.Is(err, ErrRecordNotFound) || !l.IgnoreRecordNotFoundError):
		sql, rows := fc()
		// <------ The one
		if rows == -1 {
			l.Printf(l.traceErrStr, utils.FileWithLineNum(), err, float64(elapsed.Nanoseconds())/1e6, "-", sql)
		} else {
			l.Printf(l.traceErrStr, utils.FileWithLineNum(), err, float64(elapsed.Nanoseconds())/1e6, rows, sql)
		}
	case elapsed > l.SlowThreshold && l.SlowThreshold != 0 && l.LogLevel >= Warn:
		sql, rows := fc()
		// <------ The two
		slowLog := fmt.Sprintf("SLOW SQL >= %v", l.SlowThreshold)
		if rows == -1 {
			l.Printf(l.traceWarnStr, utils.FileWithLineNum(), slowLog, float64(elapsed.Nanoseconds())/1e6, "-", sql)
		} else {
			l.Printf(l.traceWarnStr, utils.FileWithLineNum(), slowLog, float64(elapsed.Nanoseconds())/1e6, rows, sql)
		}
	case l.LogLevel == Info:
		sql, rows := fc()
		// <------ The three
		if rows == -1 {
			l.Printf(l.traceStr, utils.FileWithLineNum(), float64(elapsed.Nanoseconds())/1e6, "-", sql)
		} else {
			l.Printf(l.traceStr, utils.FileWithLineNum(), float64(elapsed.Nanoseconds())/1e6, rows, sql)
		}
	}

[jinzhu]

Can you let me know why this is needed? in which cases the fc will be nil when using GORM.

[flc1125]

Can you let me know why this is needed? in which cases the fc will be nil when using GORM.

I was writing unit tests when I discovered the problem and fixed it together.

[jinzhu]

If we can't reproduce this when using GORM's API directly, I think it is safe to keep it now to avoid unnecessary condition check.

Thank you.