Fix: Running AutoMigrate concurrently on the same model fails with various race conditions
#6680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lasse-it
changed the title
AutoMigrate concurrently on the same model fails with various race conditions
3 tasks
|
Thank you for your PR. Race issues in migrations are inevitable, particularly when running them on multiple servers. It's often impossible to remove all such issues. Auto-migration is best suited for development environments and should be executed at application initialization. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did this pull request do?
This PR makes the migrator obtain a driver-specific lock before migrating a table.
User Case Description
This makes it possible to prevent auto-migrating from failing due to concurrent migrations in distributed systems and parallel tests.
Fixes #6618.