Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: Tests fail locally if local timezone != UTC #81

Open
1 task done
mrueg opened this issue Nov 27, 2024 · 1 comment · May be fixed by #94
Open
1 task done

bug: Tests fail locally if local timezone != UTC #81

mrueg opened this issue Nov 27, 2024 · 1 comment · May be fixed by #94
Assignees
@42atomys
Labels
aspect/dex 🤖 Concerns developers' experience with the codebase domain/obvious 🟩 Represents the "known knowns" issue. It's Obviously good first issue Good for newcomers priority/low 🟩 Priority 4 - Low priority and doesn't need to be rushed state/todo 🚀 This is confirmed, will work on soon
Milestone
v1.0-rc.3

Comments

@mrueg
Copy link
Contributor

mrueg commented Nov 27, 2024

Describe the bug

running the tests locally it makes it fail when the timezone is not set to UTC.

    --- FAIL: TestDateModify/AddTenMinutes (0.00s)
        functions_test.go:100: 
                Error Trace:    /sprout/pesticide/template_test_helpers.go:45
                Error:          Not equal: 
                                expected: "07 May 24 15:14 +0000"
                                actual  : "07 May 24 17:14 +0200"
                            
                                Diff:
                                --- Expected
                                +++ Actual
                                @@ -1 +1 @@
                                -07 May 24 15:14 +0000
                                +07 May 24 17:14 +0200
                Test:           TestDateModify/AddTenMinutes

To Reproduce

  1. Set your timezone to a different one than UTC
  2. Execute tests

Expected behavior

No response

Code Snippet



Version of software


latest main checkout


Additional context


No response


Code of Conduct


    

  •  I agree to follow this project's Code of Conduct
    • 


      		
    

      
  





        



            

              
            

        

      


      
    








      

    



      

  
            

    

      
    

    


      

          @mrueg
mrueg




            added
      

  state/triage 🚦

  Has not been triaged & therefore, not ready for work

      

  type/bug 🔥

  Something isn't working

  labels


      Nov 27, 2024

    

  



    


    

    

      
    

    


      

          @42atomys
42atomys




            added
      

  good first issue

  Good for newcomers

      

  priority/low 🟩

  Priority 4 - Low priority and doesn't need to be rushed

      

  state/todo 🚀

  This is confirmed, will work on soon

      

  domain/obvious 🟩

  Represents the "known knowns" issue. It's Obviously

      

  aspect/dex 🤖

  Concerns developers' experience with the codebase

    and removed
      

  type/bug 🔥

  Something isn't working

      

  state/triage 🚦

  Has not been triaged & therefore, not ready for work

  labels


      Nov 27, 2024

    

  



    

    

      
    

    


      

          @42atomys
42atomys




          added this to the   v1.0-rc.3 milestone


      Nov 27, 2024

    

  



  

  

    
  


  

      

    @42atomys
42atomys



    mentioned this issue
    
      Nov 27, 2024
    





  


  

      
   Merged

  





  
  

      
        
      
      

  
    
    
  


    6 tasks
  





  









      

  
      



  

  @ccoVeille





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
    Contributor


      

  


  

    

  





      


        


  
    

      
          
I'll try to provide a fix for this

      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
          

  

    
  


  

      

    @ccoVeille
ccoVeille



    linked a pull request
    
      Nov 29, 2024
    

    that will
    close
    this issue





  


  

      
   Draft

  





  
  

      
        
      
      

  
    
    
  


    6 tasks
  





  













  
  

    

      

  





  




  
  

              

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  



  






  
                  




    

  


      
  

    Assignees
  



        

      

        

  
      @42atomys
  
    42atomys
    

      








      


  


  

    Labels
  



    

      

    aspect/dex 🤖

  Concerns developers' experience with the codebase
  

    domain/obvious 🟩

  Represents the "known knowns" issue. It's Obviously
  

    good first issue

  Good for newcomers
  

    priority/low 🟩

  Priority 4 - Low priority and doesn't need to be rushed
  

    state/todo 🚀

  This is confirmed, will work on soon








      

  

    

        

    Projects
  


        




    None yet




  



      


  

    
  

    Milestone
  


      
    
  
    v1.0-rc.3
  





    
      
          


  

    
      

        
    

    Development
  




            
Successfully merging a pull request may close this issue.





    


  
          
      fix(date): use available timezone if any

    
      go-sprout/sprout
    





    
  




        
      

    

  
      

  

    

      3 participants
    

    

        
          @mrueg 
        
          @ccoVeille 
        
          @42atomys