Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial work to get Fargate and Fargate_spot working #243

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

timothy-cloudopsguy
Copy link

Where do I begin? It was actually much easier to integrate with Fargate than I imagined, as everything was reusable, just really adding some if/else statements and ignoring EC2 instances for tasks that are Fargate.

Please review the code below, and make any changes to it that you feel are necessary to align it with your standards. I'm certainly not a developer, I know enough to get around.

A few things to note.

  1. For Fargate Spot, you'll need to make sure you have set up capacity providers in the cluster when you build it.
  2. When you choose Fargate in the configuration, you MUST also set an Execution Role, also in the config.
  3. When you choose Run as spot you can ignore the pricing piece, as ECS Fargate spot doesn't let you bid for prices.
  4. When you choose Fargate, it doesn't matter if you choose Privileged or not, the code will not try to make a Fargate container privileged to avoid a failure.
  5. When you choose Fargate, you cannot currently add your own Mount points to the instance. I didn't have time to work through that, as SourcePath is not a valid Fargate option and we don't need to mount things in our docker agents.
  6. If you use docker in docker to build containers, switch to Kaniko or Buildah, because you'll lose the ability to do so in Fargate
  7. Enjoy.

Cheers,
Timothy

@chadlwilson
Copy link
Member

Wow, thanks for the work here. I'm not sure when I'll have time to validate this in depth (in practice im mainly a one-man band here at the moment), but I appreciate the effort to submit a PR.

Would appreciate any feedback from anyone else who decides to build a custom plugin off this PR and tries it out.

@chadlwilson chadlwilson self-assigned this Sep 5, 2023
…s unique and doesn't affect anything when there are 100s of them running at once.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants