Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Native comments CSS #140

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

thimiraonline
Copy link
Contributor

No description provided.

@thimiraonline
Copy link
Contributor Author

@godofredoninja did you check this PR?

@godofredoninja
Copy link
Owner

Hello.

Yes I just checked it... but some changes need to be made.

To have you in the project I will merge to the main branch and after that I will make the changes.

@alexgallacher
Copy link

alexgallacher commented Aug 18, 2022

Hey guys,

Using the latest master. - As Thimiraonline confirmed on my website it appears below related articles.

https://alexgallacher.com/install-and-protect-gitlab-with-cloudflare/

Thoughts?

Alex.

@thimiraonline
Copy link
Contributor Author

Hey guys,

Using the latest master. - As Thimiraonline confirmed on my website it appears below related articles.

https://alexgallacher.com/install-and-protect-gitlab-with-cloudflare/

Thoughts?

Alex.

Send me your theme file. I will ad the comments to the correct place. email: [email protected]

@alexgallacher
Copy link

alexgallacher commented Aug 18, 2022

Hey guys,
Using the latest master. - As Thimiraonline confirmed on my website it appears below related articles.
https://alexgallacher.com/install-and-protect-gitlab-with-cloudflare/
Thoughts?
Alex.

Send me your theme file. I will ad the comments to the correct place. email: [email protected]

I've attached the file - it's just a copy of the master theme from this merge.
simply-master.zip

Alex.

@thimiraonline
Copy link
Contributor Author

Hey guys,
Using the latest master. - As Thimiraonline confirmed on my website it appears below related articles.
https://alexgallacher.com/install-and-protect-gitlab-with-cloudflare/
Thoughts?
Alex.

Send me your theme file. I will ad the comments to the correct place. email: [email protected]

I've attached the file - it's just a copy of the master theme from this merge. simply-master.zip

Alex.

Please find the attachment. Comments added to the following file

/partials/article/article-body.hbs

You can adjust the position with cut and paste the code in there.

simply-master(1).zip

@alexgallacher
Copy link

Hey guys,
Using the latest master. - As Thimiraonline confirmed on my website it appears below related articles.
https://alexgallacher.com/install-and-protect-gitlab-with-cloudflare/
Thoughts?
Alex.

Send me your theme file. I will ad the comments to the correct place. email: [email protected]

I've attached the file - it's just a copy of the master theme from this merge. simply-master.zip
Alex.

Please find the attachment. Comments added to the following file

/partials/article/article-body.hbs

You can adjust the position with cut and paste the code in there.

simply-master(1).zip

Perfect - thanks Thimira - that works great!

Appreciate the help!

Alex.

Copy link
Contributor Author

@thimiraonline thimiraonline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this PR should also merged into the repo.

@lvnilesh
Copy link
Contributor

Isn't assets/style/* generated content? I am trying to understand why this pr?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants