Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buffer Pooling #1

Open
niaow opened this issue Aug 18, 2018 · 2 comments
Open

Buffer Pooling #1

niaow opened this issue Aug 18, 2018 · 2 comments
Assignees
Labels
enhancement New feature or request WIP

Comments

@niaow
Copy link
Member

niaow commented Aug 18, 2018

This is a continuation of gorilla#9. The general idea was to create an interface implemented by sync.Pool which could be used to manage write buffers.

@niaow niaow added the enhancement New feature or request label Aug 18, 2018
@niaow niaow self-assigned this Aug 18, 2018
@niaow
Copy link
Member Author

niaow commented Aug 18, 2018

The previous implementation attempt was here: https://github.com/y3llowcake/websocket/tree/gb_buffers.

@niaow
Copy link
Member Author

niaow commented Aug 18, 2018

I git cherry-picked the commit from gb_buffers onto current master. It compiles, but there is currently a panic. I expected that changes in the code would cause something. I am investigating.

@niaow niaow added the WIP label Aug 20, 2018
@niaow niaow mentioned this issue Aug 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request WIP
Projects
None yet
Development

No branches or pull requests

1 participant