backport of linkage fix to v1.21 #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@derekparker @dbenoit17 Please review and merge. |
|
Sure. |
sipasing
force-pushed
the
backport-linkage-fix
branch
from
c3274c1 to
eee1e1c
Compare
|
@dbenoit17 Done. |
|
@dbenoit17 I used 1.21.7 as go version. Could that be the reason the tests are failing ? |
|
The test failure is due to an unrelated change in OpenSSL, just fixed in #195. If you could rebase on top of the latest changes, we should see a green test run. Thanks! |
sipasing
force-pushed
the
backport-linkage-fix
branch
from
eee1e1c to
3a46d00
Compare
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#190 fixed a linkage issue in RH builds.
This PR aims to backport that fix to the go1.21-fips-release branch