Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.22.7, 1.23.0, and 1.23.1 Go releases #227

Closed
dustinmm80 opened this issue Sep 3, 2024 · 6 comments
Closed

1.22.7, 1.23.0, and 1.23.1 Go releases #227

dustinmm80 opened this issue Sep 3, 2024 · 6 comments

Comments

@dustinmm80
Copy link

Opening this issue to track tagging releases for 1.22.7, 1.23.0, and 1.23.1 Go releases.

Last time this was done, #212.

@pmalhaire
Copy link

I did a wip for go1.23 #224 if it can help

@WarheadsSE
Copy link

👋 A nudge to maintainers, this series of updates includes important updates. How can we assist in driving these forward?

cc @ash2k @dustinmm80 @ashmckenzie: We do have 1.22.7 now 👍 (https://github.com/golang-fips/go/tree/go1.22.7-1-openssl-fips)

@derekparker
Copy link
Contributor

Sorry for the delay in responding to this issue. The main branch is currently at 1.22.7, and the PR for 1.23.1 is here: #238.

@pw20
Copy link

pw20 commented Sep 23, 2024

Hi @derekparker,
I tried to build your PR in ubuntu 20.04 fips and scripts/crypto-test.sh failed at
=== RUN TestBoringServerCurves/curve=25497
=== RUN TestBoringServerCurves/curve=25497/fipstls

panic: runtime error: index out of range [0] with length 0

goroutine 131 [running]:
crypto/tls.(*Conn).makeClientHello(0xc000398a88)
/build/golang-fips/go/src/crypto/tls/handshake_client.go:152 +0x18f9
crypto/tls.(*Conn).clientHandshake(0xc000398a88, {0x89fe98, 0xc000132d70})
/build/golang-fips/go/src/crypto/tls/handshake_client.go:264 +0x7d
crypto/tls.(*Conn).handshakeContext(0xc000398a88, {0x89fca0, 0xb10400})
/build/golang-fips/go/src/crypto/tls/conn.go:1568 +0x3a6
crypto/tls.(*Conn).HandshakeContext(...)
/build/golang-fips/go/src/crypto/tls/conn.go:1508
crypto/tls.(*Conn).Handshake(...)
/build/golang-fips/go/src/crypto/tls/conn.go:1492
crypto/tls.testHandshake.func1()
/build/golang-fips/go/src/crypto/tls/handshake_test.go:479 +0x145
created by crypto/tls.testHandshake in goroutine 130
/build/golang-fips/go/src/crypto/tls/handshake_test.go:477 +0x167

Same environment 1.22.x can pass the test. Do you see similar issue?
Thanks

@pw20
Copy link

pw20 commented Sep 24, 2024

Hi, @derekparker
Latest commit working now, thanks.

@dustinmm80
Copy link
Author

All set here, closing issue. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants