Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add negative tests for openssl #243

Merged
merged 6 commits into from
Nov 15, 2024

Conversation

derekparker
Copy link
Contributor

This patch adds assertions around expected failures when using OpenSSL in FIPS mode.

This patch adds assertions around expected failures when using OpenSSL
in FIPS mode.
@dbenoit17 dbenoit17 requested review from ueno and dbenoit17 November 11, 2024 21:09
Copy link
Collaborator

@ueno ueno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM; just added some questions on the error conditions.

patches/022-openssl-negative-tests.patch Show resolved Hide resolved
patches/022-openssl-negative-tests.patch Show resolved Hide resolved
patches/022-openssl-negative-tests.patch Show resolved Hide resolved
@derekparker
Copy link
Contributor Author

Updates added to the end of the patch.

@derekparker
Copy link
Contributor Author

@ueno if you want to take a look at the updates (at the end of the patch) that would be great, then I will merge after that.

Copy link
Collaborator

@ueno ueno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than nits on logging, this looks good to me.

patches/022-openssl-negative-tests.patch Outdated Show resolved Hide resolved
patches/022-openssl-negative-tests.patch Outdated Show resolved Hide resolved
patches/022-openssl-negative-tests.patch Outdated Show resolved Hide resolved
@derekparker derekparker merged commit b802af5 into golang-fips:main Nov 15, 2024
5 of 6 checks passed
@derekparker derekparker deleted the openssl-negative-tests branch November 15, 2024 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants