-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add negative tests for openssl #243
Add negative tests for openssl #243
Conversation
This patch adds assertions around expected failures when using OpenSSL in FIPS mode.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LGTM; just added some questions on the error conditions.
Updates added to the end of the patch. |
@ueno if you want to take a look at the updates (at the end of the patch) that would be great, then I will merge after that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than nits on logging, this looks good to me.
This patch adds assertions around expected failures when using OpenSSL in FIPS mode.