Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/checkheader erroneously passes with OpenSSL 1.0.2 headers #99

Open
corhere opened this issue Aug 3, 2023 · 0 comments
Open

cmd/checkheader erroneously passes with OpenSSL 1.0.2 headers #99

corhere opened this issue Aug 3, 2023 · 0 comments

Comments

@corhere
Copy link
Contributor

corhere commented Aug 3, 2023

The header openssl/kdf.h was first added in OpenSSL 1.1.0. It does not exist in OpenSSL 1.0.2. Despite shims.h referencing the aforementioned header, checkheader 1.0.2 passes in CI.

// #include <openssl/kdf.h>

Expected:

/var/folders/8p/tzn5bkn967vfgttpr2d2kpjm0000gq/T/go-crypto-openssl-4068040127.c:53:10: fatal error: 'openssl/kdf.h' file not found
#include <openssl/kdf.h>
         ^~~~~~~~~~~~~~~
1 error generated.
2023/08/03 19:29:24 exit status 1
exit status 1

I can reproduce the spurious passing check on an Ubuntu 20.04 box with the libssl-dev package (OpenSSL 1.1.1) installed. Presumably the GHA runner image is the same.

Inserting the ossl-include directory at the top of the include search path list is not sufficient to exclude the system OpenSSL headers from being resolved as a fallback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant