Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try to get rid of protoc begin required for golem-cli #744

Closed
vigoo opened this issue Aug 11, 2024 · 4 comments · Fixed by #1176
Closed

Try to get rid of protoc begin required for golem-cli #744

vigoo opened this issue Aug 11, 2024 · 4 comments · Fixed by #1176
Assignees
@vigoo
Labels
cli
Milestone
Golem 1.2

Comments

@vigoo
Copy link
Contributor

vigoo commented Aug 11, 2024

No description provided.

@vigoo vigoo added the cli label Aug 11, 2024
@vigoo vigoo added this to the Golem Open Source 1.0 milestone Aug 11, 2024
@vigoo
Copy link
Contributor Author

vigoo commented Aug 12, 2024

This is probably only possible if TypeAnnotatedValue in wasm-rpc is converted back to a non-protobuf generated type.

@vigoo
Copy link
Contributor Author

vigoo commented Aug 14, 2024

Alternatively we can try to just publish cli binaries for some platforms, see https://github.com/bytecodealliance/cargo-component/blob/main/.github/workflows/publish-binaries.yml

@vigoo
Copy link
Contributor Author

vigoo commented Aug 14, 2024

We don't have time for this before 1.0 so removing from the milestone (but will attempt to publish binaries)

@vigoo vigoo removed this from the Golem Open Source 1.0 milestone Aug 14, 2024
@vigoo vigoo mentioned this issue Dec 6, 2024
Closed
@vigoo vigoo self-assigned this Dec 6, 2024
@vigoo
Copy link
Contributor Author

vigoo commented Dec 6, 2024

This and #1073 will be solved by the same set of changes that are refactoring the core crates and introducing optional features to them.

@vigoo vigoo added this to the Golem 1.2 milestone Dec 6, 2024
This was referenced Dec 6, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vigoo vigoo

Labels
cli
Projects
None yet
Milestone
Golem 1.2
Development

Successfully merging a pull request may close this issue.

Crate features and dependency cleanup golemcloud/golem
1 participant
@vigoo