Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invocation events via websocket #774

Closed
vigoo opened this issue Aug 19, 2024 · 1 comment
Closed

Invocation events via websocket #774

vigoo opened this issue Aug 19, 2024 · 1 comment

Comments

@vigoo
Copy link
Contributor

vigoo commented Aug 19, 2024

Currently we are only emitting the following worker events through websocket:

  • stdout
  • stderr
  • log

With the new --connect feature of golem-cli worker invoke, it's confusing that there is no way to know which log messages were emitted by a particular invoation. To solve this, we could extend the set of worker events and emit a "invocation start" and "invocation end" event through the broadcast channel (ending up in the websocket connection of connect). If these messages contain the idempotency key of the invocation, then clients like golem-cli can filter out messages before/after the invocation (and can await the last emitted message instead of cancelling the stream as soon as we get a result value).

@vigoo
Copy link
Contributor Author

vigoo commented Dec 6, 2024

This is already implemented.

@vigoo vigoo closed this as completed Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant