Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROS3 Driver Addition #82

Open
rgoss opened this issue May 6, 2021 · 0 comments
Open

ROS3 Driver Addition #82

rgoss opened this issue May 6, 2021 · 0 comments

Comments

@rgoss
Copy link

rgoss commented May 6, 2021

I’m not sure this is really an issue, but given the previous discussions on hdf5 version functionality > 1.8 I figured I would just create one. I’ve added support for the ROS3 driver and wasn’t sure if I should submit a pull request. Fork of the project is here and the changes are in the ros3 branch. I ended up creating a new method for opening files with props (OpenFileWithProps), but since there were comments of “//FIXME: file props” in the current OpenFile method, I wasn't sure if there were changes already being considered. Regardless, let me know if you want a pull request but this functionality does require hdf5 version 1.10.6 or higher. I’m currently running it with 1.10.7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant