Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop BigNumber #2

Open
hurrymaplelad opened this issue Oct 30, 2015 · 1 comment
Open

Drop BigNumber #2

hurrymaplelad opened this issue Oct 30, 2015 · 1 comment
Assignees

Comments

@hurrymaplelad
Copy link

It's ~16k minified. We're only using it for consistent rounding. We prefer to serialize cents as JSON Numbers, so we already don't support arbitrarily large numbers. This is not something we will likely ever need to support for a single shopper's flow. Let's keep things simple by preferring Number representations and acknowledging their limitations. Let's add larger libraries for high precision math and arbitrarily large ints only where and once we need them (accounting systems?)

@hurrymaplelad hurrymaplelad self-assigned this Oct 30, 2015
@hurrymaplelad
Copy link
Author

Also, with integer cents, Math.round() is stable and predictable. Seems like we only need one of BigNumber or integer cents for predictable money math.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant