Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement suggestions #8

Open
ghost opened this issue Jul 24, 2018 · 0 comments
Open

Improvement suggestions #8

ghost opened this issue Jul 24, 2018 · 0 comments

Comments

@ghost
Copy link

ghost commented Jul 24, 2018

Unsubscribe single-use event handlers after use

--stream.on('close', closeHandler);
--stream.on('end', closeHandler);
++stream.once('close', closeHandler);
++stream.once('end', closeHandler);

Avoid unnecessary closure

    stream.on('data', function(data) {
      tasks.push(data);
      if (running < concurrency) {
        startNextTask();
      } else {
--        stream.pause();
++        this.pause();
      }
    });
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants