Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graph Vizualization #149

Open
fcbond opened this issue Nov 4, 2021 · 5 comments
Open

Graph Vizualization #149

fcbond opened this issue Nov 4, 2021 · 5 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@fcbond
Copy link
Collaborator

fcbond commented Nov 4, 2021

It would be great to add the graph visualization code @ekaf added to NTLK.

See: nltk/nltk@8f91325

Although @goodmami may consider this out of scope, ...

@goodmami goodmami added the enhancement New feature or request label Nov 4, 2021
@goodmami
Copy link
Owner

goodmami commented Nov 4, 2021

Yes, those graphs look very nice and useful.

And you're right that I currently consider it out of scope, but I'll think about it as I reevaluate the role Wn serves (for instance, I'm adding the describe() function and wn.validate module). One thing I've thought about is adding some web API endpoints for relation paths so that a web frontend could construct the visualizations (e.g., in SVG) using the data in the response.

@arademaker
Copy link

An web interface would be nice! Is there any general documentation about the architecture of the lib and plans?

@arademaker
Copy link

On the other hand, another project for a web interface can be a wrapper to wn

@goodmami
Copy link
Owner

goodmami commented Nov 4, 2021

@arademaker The idea is that the web client would be a separate project, similar to how delphin-viz works on top of the web API provided by other tools.

On the topic of scope creep, the existing wn.web module is already a bit excessive, and it could easily be spun out into a separate package. If we start having multiple related codebases, it might make sense to create a GitHub organization for them, or maybe put them under globalwordnet or something.

edit: note that the above paragraph is just some thoughts, and not concrete plans

@goodmami goodmami added the good first issue Good for newcomers label Nov 5, 2021
@goodmami
Copy link
Owner

goodmami commented Nov 5, 2021

After talking with @fcbond, I think we'll stick with with a monolithic model for now and spin out modules later if we need a leaner package. So I think this could be included somehow in Wn. To that end, some notes:

  • As it is not core functionality, if it requires new dependencies, they should be part of an installation extra (AKA optional dependencies).
  • It should work for Windows, macOS, and Linux.
  • It would be nice if this works with the wn.web package somehow. Whether that's delivering the raw data through a web endpoint to some Javascript-based renderer or directly serving SVG is undecided.
  • At the same time, it would be great if there were an option to output a local file that could be used in LaTeX/Word/etc. documents.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants