Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong define in assembly definition file #190

Open
YisharPixelsHub opened this issue Apr 29, 2024 · 2 comments
Open

Wrong define in assembly definition file #190

YisharPixelsHub opened this issue Apr 29, 2024 · 2 comments

Comments

@YisharPixelsHub
Copy link

The assembly definition file has the wrong value for the Version Defines field.
image

As you can see in the screenshot both versions of ARFoundation use the same flag, but the version [5.0,6.0) should use ARCORE_USE_ARF_5.
This is overriden with the ARCORE_USE_ARF_5 in PlayerSettings when building an app, but not in editor or when building AssetBundles, leading to an error because editor and platform builds have different serialized fields on the ARCoreExtensions script.

As a workaround, the .asmdef of the package can be edited in a text editor and the value can be changed to the correct oneARCORE_USE_ARF_5, and unity will apply it after that.

@Jocke155
Copy link

Do you know if this causes any issues when building?

@YisharPixelsHub
Copy link
Author

It causes issues when building AssetBundles. It does not when building the app IF the user already applied the ARCORE_USE_ARF_5 in PlayerSettings > Other Settings > Scripting Define Symbols, as it has higher priority in the #IF chain on ARCoreExtensions.cs (and maybe more scripts).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants