Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chrome special keyword flags are outdated #168

Open
mstange opened this issue May 27, 2024 · 0 comments
Open

Chrome special keyword flags are outdated #168

mstange opened this issue May 27, 2024 · 0 comments

Comments

@mstange
Copy link

mstange commented May 27, 2024

// 1ULL << 61 and 1ULL << 62 are special values that indicate to Chrome to
// enable all enabled-by-default and disabled-by-default categories
// respectively.
const PCWSTR other_events_group_name = L"All enabled-by-default events"; // 0x2000000000000000
const PCWSTR disabled_other_events_group_name = L"All disabled-by-default events"; // 0x4000000000000000
uint64_t other_events_keyword_bit = 1ULL << 61;
uint64_t disabled_other_events_keyword_bit = 1ULL << 62;

userProviders += stringPrintf(L"+chrome:0x%llx", (0x8000000000000000 | chromeKeywords_));

These bits were changed in https://chromium-review.googlesource.com/c/chromium/src/+/2171974 :

Bits 61 and 62 are now bits 46 and 47. And the ORing with 0x8000000000000000 seems to no longer be suggested - I'm not sure why the old code said "Note that bit 63 (MSB) must always be set", it's possible that this was never true.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant