Skip to content
This repository has been archived by the owner on Oct 11, 2023. It is now read-only.

Does not build cleanly with -Wsign-compare #487

Open
adetaylor opened this issue Feb 2, 2023 · 2 comments
Open

Does not build cleanly with -Wsign-compare #487

adetaylor opened this issue Feb 2, 2023 · 2 comments

Comments

@adetaylor
Copy link

Experimenting with building bits of centipede with Chromium, which uses -Wsign-compare

../../third_party/centipede/src/runner.cc:598:29: error: comparison of integers of different signs: 'int' and 'uint64_t' (aka 'unsigned long') [-Werror,-Wsign-compare]
        rand_r(&seed) % 100 < state.run_time_flags.crossover_level) {
@adetaylor
Copy link
Author

(obviously this is trivial to work around, I just thought I should let you know)

@kcc
Copy link
Contributor

kcc commented Feb 2, 2023

thanks will fix. (unless someone wants to beat me to that).
Good idea to also add -Wsign-compare to the build flags.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants