-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Elemental2 wrapper for DOMParser #157
Comments
@jDramaix This is defined in https://github.com/google/closure-compiler/blob/master/externs/browser/gecko_xml.js though I don't see us using any extern named gecko (though this one doesn't seem Mozilla specific) |
When I asked the closure-compiler maintainers some years ago about the different browser-named extern files, they indicated that this was often the original source of that type, and that it wouldn't be beneficial to migrate the externs out of that file and into something common now that the type is standardized. |
Yes we do not use any specific browser extern files. If the api has been standardized we need to move the api in another extern file (w3c_xml.js in this case). Contribution is welcome :) |
It looks like my memory is faulty or policy has changed: I can't find the specific conversation where gwt community members were asked to not bulk migrate standardized entries, but google/closure-compiler#2478 is one such conversation. The entire gecko_dom.js is standardized now (with the exception of the serializer method |
The problem is that |
@jDramaix elemental also includes w3c_range that uses TrustedHTML, is that also a problem? https://github.com/google/closure-compiler/blob/46131b1844fb070316a98c5b4c047ee3d786553e/externs/browser/w3c_range.js#L250 elemental2/java/elemental2/dom/BUILD Line 66 in 33cea8e
|
The definition of the types are there but there is no J2CL/GWT way to instantiate them (I don't even know a standard way to instantiate them on JS). Also, the version of |
So is this issue blocked by FireFox+Safari support for trusted types? (mozilla/standards-positions#20, https://webkit.org/standards-positions/ doesn't even mention it).
|
Can't find
DOMParser
from the current elemental2 library.https://developer.mozilla.org/en-US/docs/Web/API/DOMParser
Shall we support it as well?
The text was updated successfully, but these errors were encountered: