Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle standard library functions in the analysis engine #312

Open
guodongli-google opened this issue Jun 12, 2021 · 1 comment
Open

Handle standard library functions in the analysis engine #312

guodongli-google opened this issue Jun 12, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@guodongli-google
Copy link
Contributor

Bug report

Describe the bug
Go has a large number of library functions in the standard package, whose source code may be missing and the propagation analysis may have no clue on their semantics.
While we can hard-code the support for some known ones, e.g. fmt.Printf(...), it may be impractical to do that for all the functions. If we over-approximate their semantics, then false positives will be generated.
This bug is to track the progress of the support for these library functions.

@guodongli-google guodongli-google added the bug Something isn't working label Jun 12, 2021
@mlevesquedion
Copy link
Contributor

I see you have already added a hook visitKnownFunction for this purpose.

FWIW, the non-EAR version of the analysis already supports this to a large extent. See the internal/pkg/propagation/summary package.

Perhaps these summaries can be used by EAR as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants