Optimize memory allocation in InternalContext by lazy initialization #1807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
perf(InternalContext): Optimize memory allocation by lazy initializing constructionContexts
The current implementation of InternalContext eagerly initializes the constructionContexts map,
leading to unnecessary memory allocation when retrieving singleton instances via Injector#getInstance(...)
or Provider#get(). This commit lazily initializes the constructionContexts map in the getConstructionContext
method, avoiding the creation of the IdentityHashMap and associated Object array when not needed.
This optimization should significantly reduce memory overhead in scenarios where singleton instances
are accessed frequently, improving the overall memory footprint of applications using Guice.
Resolves: #1802