Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Will you consider add user info column in ml-metadata tables ? #141

Open
liujiong1982 opened this issue Jan 19, 2022 · 5 comments
Open

Will you consider add user info column in ml-metadata tables ? #141

liujiong1982 opened this issue Jan 19, 2022 · 5 comments

Comments

@liujiong1982
Copy link

Will you consider add user info column in ml-metadata tables ?
Currently I am adding user info column in ContextProperty、ExecutionProperty and ArtifactProperty, but in some situations, it is very difficult to filter user in **Property

@BrianSong
Copy link
Collaborator

BrianSong commented Feb 1, 2022

Hi Jiong,

For the "user" here, could you be more specific? Is it the user that creates these Artifact, Execution and Context? If that's the case, could you consider store different users in different databases, or you need some cross-user features for your project?

@liujiong1982
Copy link
Author

Hi Jiong,

For the "user" here, could you be more specific? Is it the user that creates these Artifact, Execution and Context? If that's the case, could you consider store different users in different databases, or you need some cross-user features for your project?

The user refer to creator of Artifact, Execution and Context, is there a plan to store this information in mlmd? For example, I need to search artifacts by creator
what do you mean by store different users in different databases?

@BrianSong
Copy link
Collaborator

BrianSong commented Mar 30, 2022

I see your point. Unfortunately, there is no plan to add this column. My advice would be the same as your original statement: create a user column in **Property and store that information.

I saw you mention " in some situations, it is very difficult to filter user in **Property", could you be more specific on this? Actually, you can easily filter them using MLMD Declarative Nodes Filtering.

@liujiong1982
Copy link
Author

I see your point. Unfortunately, there is no plan to add this column. My advice would be the same as your original statement: create a user column in **Property and store that information.

I saw you mention " in some situations, it is very difficult to filter user in **Property", could you be more specific on this? Actually, you can easily filter them using MLMD Declarative Nodes Filtering.

property is a variable, not fixed name, while user is a fixed attribute in my situation

@BrianSong
Copy link
Collaborator

BrianSong commented Apr 4, 2022

I am not sure if I understand you correctly, can you give some concrete examples? Even though the user is a fixed attribute in your situation, I do not see any blockers for you to "create a user column in **Property, store that information and filter them using MLMD Declarative Nodes Filtering.".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants