Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly define byte vs string types in source and cache api boundaries #99

Open
jaqx0r opened this issue Nov 1, 2019 · 0 comments
Open

Comments

@jaqx0r
Copy link
Contributor

jaqx0r commented Nov 1, 2019

While doing the python3 conversion I realised that the data handlers never cared about encodings and now we've got a mix of ascii and utf8 encodings between sources and caches. I'd like to formally state what types go where and enforce it.

For example, is nssdb a utf8 compatible cache? Or does it have to be ascii only? I think OpenLDAP, Samba4, etc allow utf8?

Should the Updater deal in Python str types and convert to bytes or deal with bytes only and avoid any encoding at all?

Once decided on, can pytype annotations force us to get conforming code?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant