Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should patch be shared with reporter before release? #6

Open
Marcono1234 opened this issue Nov 24, 2022 · 1 comment
Open

Should patch be shared with reporter before release? #6

Marcono1234 opened this issue Nov 24, 2022 · 1 comment

Comments

@Marcono1234
Copy link

Hello,

currently the guide and the runbook mention that the reporter can assist with developing the patch if they want to. However, if they do not assist in developing the patch, would it be reasonable nonetheless to share the patch with the reporter before the release so they can verify that it covers all corner cases? Though on the other hand that could further delay publication of the release, so that would be an optional thing to do.

Unfortunately I cannot provide specific examples but I remember vaguely that there have been situations in the past where developers thought their patch fixed all issues, created a release but then it turned out that the patch was incomplete.

@emckean
Copy link
Collaborator

emckean commented Dec 8, 2022

inviting @u269c into this conversation :)

@Laurry-gee
Copy link

Hello,

currently the guide and the runbook mention that the reporter can assist with developing the patch if they want to. However, if they do not assist in developing the patch, would it be reasonable nonetheless to share the patch with the reporter before the release so they can verify that it covers all corner cases? Though on the other hand that could further delay publication of the release, so that would be an optional thing to do.
[email protected]
Unfortunately I cannot provide specific examples but I remember vaguely that there have been situations in the past where developers thought their patch fixed all issues, created a release but then it turned out that the patch was incomplete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants