Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for version_file in pkg_tar2rpm #63

Open
phlax opened this issue Jul 6, 2021 · 2 comments
Open

Add support for version_file in pkg_tar2rpm #63

phlax opened this issue Jul 6, 2021 · 2 comments

Comments

@phlax
Copy link
Contributor

phlax commented Jul 6, 2021

It would be very helpful if a version file was supported for setting the package version - as eg pkg_deb does

if a version file could be passed in it would allow pkg_tar2rpm to read version info directly from eg a VERSION file rather than having to duplicate/hardcode the current version in BUILD/bzl files in addition to the canonical setting

@jarondl
Copy link
Collaborator

jarondl commented Nov 15, 2021

What is the structure of the VERSION file? are we talking about a text file containing only one string? And do you want to pass it as the version flag to rpmpack? If so, does this only require changes in the bzl file..
https://github.com/google/rpmpack/blob/master/def.bzl#L6

@phlax
Copy link
Contributor Author

phlax commented Nov 15, 2021

are we talking about a text file containing only one string?

yep, i think that is how pkg_deb works (cf https://docs.bazel.build/versions/1.0.0/be/pkg.html#pkg_deb)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants