-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build.rs: FreeBSD support #62
Comments
Please at least do the libc++ thing, anything depending on unmodified shaderc-rs is literally unusable because the |
Thanks for the comment. But I'm not familiar with FreeBSD and don't have a FreeBSD environment for developing to make sure everything functions properly. If you can send a pull request that would be awesome! |
Well, there's the whole CLA thing. I don't remember if the CLA form requires lots of personal information still, but I can't even sign into the google account for my current email address because it insists on a phone number >_< Anyway my previous comment is a bit wrong, there's actually no You can get away with no testing, I have already tested the following very obvious changes: just treat shaderc-rs/shaderc-sys/build/build.rs Line 168 in 5784243
shaderc-rs/shaderc-sys/build/build.rs Line 277 in 5784243
shaderc-rs/shaderc-sys/build/build.rs Line 345 in 5784243
|
emit_std_cpp_link
:("freebsd", _)
is like("macos", _)
, we use libc++match (target_os.as_str(), target_env.as_str())
, it would make sense to move("linux", _)
code to(_, _)
so that it works on any unix-like platform, and useemit_std_cpp_link
there instead of hardcodingstdc++
"/usr/local/lib"
fortarget_os == "freebsd"
would be niceThe text was updated successfully, but these errors were encountered: