Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💡 [REQUEST] - Fix warnings in cloudrun job in release workflow #334

Open
1 task done
lvaylet opened this issue Feb 27, 2023 · 1 comment
Open
1 task done

💡 [REQUEST] - Fix warnings in cloudrun job in release workflow #334

lvaylet opened this issue Feb 27, 2023 · 1 comment
Assignees
Labels

Comments

@lvaylet
Copy link
Collaborator

lvaylet commented Feb 27, 2023

Summary

The latest cloudrun job in the deploy workflow for release 2.3.4 reported 3 warnings that should be fixed before they turn into errors in future releases.

https://github.com/google/slo-generator/actions/runs/4281247944

Basic Example

Screenshots

![DESCRIPTION](LINK.png)

Drawbacks

None identified.

Unresolved questions

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@lvaylet lvaylet added the ci label Feb 27, 2023
@lvaylet lvaylet self-assigned this Mar 1, 2023
@lvaylet
Copy link
Collaborator Author

lvaylet commented Nov 17, 2023

Partially fixed by #386.

Not sure how to fix the first two warnings. They depend on the tomchv/[email protected] GitHub Action, and it looks like it is not actively maintained.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant