feat: add adhoc debug logger package #1669
Conversation
feywind
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
|
Here is the summary of possible violations 😱 There are 2 possible violations for not having product prefix.
The end of the violation section. All the stuff below is FYI purposes only. Here is the summary of changes. You are about to add 2 region tags.
This comment is generated by snippet-bot.
|
| @@ -1,4 +1,5 @@ | |||
| { | |||
| "gax": "4.5.0", | |||
| "tools": "0.4.6" | |||
| "tools": "0.4.6", | |||
| "logging-utils": "0.0.0" | |||
There was a problem hiding this comment.
name and version disagree with what's in package.json (google-logging-utils and 0.0.2) - should these match?
There was a problem hiding this comment.
Hopefully the 0.0.2 is published experimentally! Also - is this name already taken? https://www.npmjs.com/package/logging-utils
| "fix": "gts fix", | ||
| "prepare": "npm run compile", | ||
| "precompile": "gts clean", | ||
| "samples-test": "echo no samples 🙀", |
There was a problem hiding this comment.
There is a sample, should there either be a test or should this actually say no samples tests?
| "directory": "adhoc-logging/samples" | ||
| }, | ||
| "engines": { | ||
| "node": ">=14" | ||
| }, | ||
| "dependencies": { | ||
| "@google-cloud/adhoc-logging": "0.0.1" |
There was a problem hiding this comment.
should these be updated to say logging-utils and not adhoc-logging?
There was a problem hiding this comment.
Plus one, I think this should be logging-utils!
| "directory": "adhoc-logging/samples" | ||
| }, | ||
| "engines": { | ||
| "node": ">=14" | ||
| }, | ||
| "dependencies": { | ||
| "@google-cloud/adhoc-logging": "0.0.1" |
There was a problem hiding this comment.
Plus one, I think this should be logging-utils!
| * variables) to determine what logging they want to see at runtime. This | ||
| * isn't necessarily fed into the console, but is meant to be under the | ||
| * control of the user. The kind of logging that will be produced by this | ||
| * is more like "call retry happened", not "event you'd want to record |
There was a problem hiding this comment.
| * is more like "call retry happened", not "event you'd want to record | |
| * is more like "call retry happened", not "events you'd want to record |
| assert.deepStrictEqual(sink.logs, []); | ||
| }); | ||
|
|
||
| it('obeys "all"', () => { |
There was a problem hiding this comment.
nit: more descriptive test name? What should 'all' be returning?
|
Browser tests are failing because I moved them to Node 18. You can wait for this PR to be merged first, or just copy over the .kokoro/**/*browser.cfg/setup/run files from that PR. Or I could admin merge it, since it really doesn't change anything in gax - depends on the speed with which you need it! |
This adds a new pseudo-mono-repo package for adhoc debug logging. It's meant to be pulled in across any library and/or GAPIC to provide the ability to do the equivalent of "printf debugging", but with filtering and a disable flag.
Working group spec doc available upon request :)