New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up new system tests #7709

Open

bshaffer opened this issue Sep 27, 2024 · 0 comments

Contributor

bshaffer commented Sep 27, 2024 •

edited

Loading

PR #7695 introduced system tests as part of our workflow, but there's still a lot of work to be done.

As mentioned in feat(tests): organize workflows, add system tests #7695 (comment), we should keep all ENV vars in one place and define them as constants
Remove tests/System/bootstrap.php files if possible, or consolidate them to use one in Core
Cleanup use of PROJECT_ID environment variable, in favor of GOOGLE_PROJECT_ID, GOOGLE_CLOUD_PROJECT, or remove it all together
Cleanup use of TestHelpers to make all tests consistent.

The text was updated successfully, but these errors were encountered:

bshaffer mentioned this issue

feat(tests): organize workflows, add system tests #7695

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment