Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: unmanaged dependency check #3145

Merged
merged 6 commits into from
Mar 22, 2024
Merged

ci: unmanaged dependency check #3145

merged 6 commits into from
Mar 22, 2024

Conversation

suztomo
Copy link
Member

@suztomo suztomo commented Feb 14, 2024 •
edited
Loading

Cont of #3108. Now we have the BOM.

b/320677879

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/java-bigquery API. labels Feb 14, 2024
@suztomo
Copy link
Member Author

suztomo commented Feb 21, 2024 •
edited
Loading

Running Unmanaged Dependency Check against /home/runner/work/java-bigquery/java-bigquery/google-cloud-bigquery-bom/pom.xml This pull request seems to add new third-party dependency, [org.apache.arrow:arrow-memory-core, org.threeten:threeten-extra, org.apache.arrow:arrow-memory-netty, org.apache.arrow:arrow-vector, org.apache.arrow:arrow-format, com.google.flatbuffers:flatbuffers-java], among the artifacts listed in ./google-cloud-bigquery-bom/pom.xml.

@suztomo
Copy link
Member Author

suztomo commented Mar 4, 2024

Now the shared dependencies BOM has the third-party dependencies (#3176, merged). The check should succeed.

@suztomo
Copy link
Member Author

suztomo commented Mar 4, 2024 •
edited
Loading

"Unmanaged dependency check / unmanaged_dependency_check (pull_request) Successful"

"Test-Samples-java-bigquery (cloud-java-ci-sample)" is failing until #3171 fixes it. This is irrelevant to the unmanaged dependency check.

@suztomo suztomo marked this pull request as ready for review March 4, 2024 20:11
@suztomo suztomo requested review from a team as code owners March 4, 2024 20:11
@suztomo suztomo requested a review from shollyman March 4, 2024 20:11
@suztomo suztomo added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 4, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 4, 2024
@suztomo
Copy link
Member Author

suztomo commented Mar 22, 2024

Did I forget to merge this?

@JoeWang1127
Copy link
Contributor

Did I forget to merge this?

I think so.

@suztomo suztomo merged commit 9438f2c into main Mar 22, 2024
21 of 22 checks passed
@suztomo suztomo deleted the unmanaged_dependencies_check branch March 22, 2024 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhongChuong PhongChuong PhongChuong approved these changes

@shollyman shollyman Awaiting requested review from shollyman shollyman is a code owner automatically assigned from googleapis/api-bigquery

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/java-bigquery API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@suztomo @JoeWang1127 @PhongChuong