Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: demonstrate exporting OpenTelemetry logs to Google Cloud #2573

Merged
merged 1 commit into from
Aug 30, 2024
Merged

chore: demonstrate exporting OpenTelemetry logs to Google Cloud #2573

merged 1 commit into from
Aug 30, 2024

Conversation

agrawal-siddharth
Copy link
Contributor

Monitoring

@agrawal-siddharth agrawal-siddharth requested review from a team as code owners July 22, 2024 23:54
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Jul 22, 2024
@generated-files-bot Generated Files Bot
Copy link

generated-files-bot bot commented Jul 22, 2024 •
edited
Loading

Warning: This pull request is touching the following templated files:

  • samples/install-without-bom/pom.xml
  • samples/snapshot/pom.xml
  • samples/snippets/pom.xml

@product-auto-label product-auto-label bot added the api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. label Jul 22, 2024
@agrawal-siddharth agrawal-siddharth force-pushed the exportOT branch 2 times, most recently from 5bf2c62 to 5b6cffa Compare July 23, 2024 19:16
@yirutang yirutang requested a review from PhongChuong July 23, 2024 21:37
yirutang
yirutang approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@yirutang yirutang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please wait for Java lib owner's approval.

PhongChuong
PhongChuong reviewed Jul 26, 2024
View reviewed changes
Copy link
Contributor

@PhongChuong PhongChuong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. Just some minor suggestions.

samples/snippets/src/test/java/com/example/bigquerystorage/ExportOpenTelemetryIT.java Show resolved Hide resolved
samples/install-without-bom/pom.xml Outdated Show resolved Hide resolved
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Aug 15, 2024
@snippet-bot Snippet Bot
Copy link

snippet-bot bot commented Aug 15, 2024 •
edited
Loading

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@agrawal-siddharth agrawal-siddharth force-pushed the exportOT branch 6 times, most recently from 9aa5743 to ee97b19 Compare August 30, 2024 14:07
@agrawal-siddharth agrawal-siddharth merged commit 5852ea1 into googleapis:main Aug 30, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhongChuong PhongChuong PhongChuong left review comments

@yirutang yirutang yirutang approved these changes

@shollyman shollyman Awaiting requested review from shollyman shollyman is a code owner automatically assigned from googleapis/api-bigquery

Assignees
No one assigned
Labels
api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@agrawal-siddharth @yirutang @PhongChuong