chore: Client change for using request priority to enable flow control #1900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: s
kongweihan
force-pushed
the
kongwh-request-priority-patch-1
branch
2 times, most recently
from
ec8d677
to
f29295e
Compare
kongweihan
force-pushed
the
kongwh-request-priority-patch-1
branch
from
f29295e
to
0090371
Compare
product-auto-label
bot
added
size: m
In this stage, client needs to do 3 things: 1. Always create flow control callable regardless of client flag 2. Make sure the entire callable behave like no-op if RateLimitInfo is not present. 3. Make sure client runs flow control as long as RateLimitInfo is present, regardless of client flag. Meanwhile, setting client flag would still set the feature flag. On server side, we'll compute and return RateLimitInfo if server side sees priority is low.
kongweihan
force-pushed
the
kongwh-request-priority-patch-1
branch
from
0090371
to
761bab7
Compare
…ty-patch-1 Change-Id: Ib9f2520b70cc570d76dbe04e5ecd1ae4a28ac8c5
Change-Id: I721ad64ce49b0310eb44d86e3b171ab2bef46437
igorbernstein2
changed the title
Change-Id: Ibda6daed72f0f267ad741836701848f33c2d5377
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this stage, client needs to do 3 things:
Meanwhile, setting client flag would still set the feature flag.
On server side, we'll compute and return RateLimitInfo if AFE sees priority is low.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️
If you write sample code, please follow the samples format.